update rules

http-api/app/rules/user.py

@@ -46,20 +46,26 @@ def update_user(
             },
             cond_expr='attribute_exists(sk)',
         )
+
+        class RateLimitError(BadRequestError):
+            def __init__(self, msg: str):
+                super().__init__('Update limit reached')
+
         # Prevent the user from updating more than once every 24 hours
         transact.put(
             item={
                 'id': user.id,
-                'sk': 'last_profile_edit',
+                'sk': 'rate_limit#user_update',
                 'create_date': now_,
                 'ttl': ttl(start_dt=now_ + timedelta(hours=24)),
             },
+            exc_cls=RateLimitError,
             cond_expr='attribute_not_exists(sk)',
         )
 
         class CPFConflictError(BadRequestError):
             def __init__(self, msg: str):
-                super().__init__('Cpf already exists')
+                super().__init__('CPF already exists')
 
         if user.cpf != old_cpf:
             transact.put(
@@ -90,6 +96,7 @@ def add_email(
     now_ = now()
 
     with persistence_layer.transact_writer() as transact:
+        # Ensure email is searchable
         transact.update(
             key=KeyPair(id, '0'),
             update_expr='ADD emails :email',
@@ -100,7 +107,7 @@ def add_email(
         transact.put(
             item={
                 'id': id,
-                'sk': f'emails#{email}',
+                'sk': ComposeKey(email, prefix='emails'),
                 'email_primary': False,
                 'email_verified': False,
                 'create_date': now_,
@@ -112,6 +119,7 @@ def add_email(
             def __init__(self, msg: str):
                 super().__init__('Email already exists')
 
+        # Prevent duplicate emails
         transact.put(
             item={
                 'id': 'email',
@@ -138,8 +146,10 @@ def del_email(
         transact.delete(key=KeyPair('email', email))
         transact.delete(
             key=KeyPair(id, ComposeKey(email, prefix='emails')),
-            cond_expr='email_primary <> :primary',
-            expr_attr_values={':primary': True},
+            cond_expr='email_primary <> :email_primary',
+            expr_attr_values={
+                ':email_primary': True,
+            },
             exc_cls=BadRequestError,
         )
         transact.update(
@@ -162,16 +172,16 @@ def set_email_as_primary(
     persistence_layer: DynamoDBPersistenceLayer,
 ):
     now_ = now()
-    expr = 'SET email_primary = :email_primary, update_date = :update_date'
+    expr = 'SET email_primary = :email_primary, updated_at = :updated_at'
 
     with persistence_layer.transact_writer() as transact:
         # Set the old email as non-primary
         transact.update(
-            key=KeyPair(id, ComposeKey(old_email, 'emails')),
+            key=KeyPair(id, ComposeKey(old_email, prefix='emails')),
             update_expr=expr,
             expr_attr_values={
                 ':email_primary': False,
-                ':update_date': now_,
+                ':updated_at': now_,
             },
         )
         # Set the new email as primary
@@ -180,17 +190,17 @@ def set_email_as_primary(
             update_expr=expr,
             expr_attr_values={
                 ':email_primary': True,
-                ':update_date': now_,
+                ':updated_at': now_,
             },
         )
         transact.update(
             key=KeyPair(id, '0'),
             update_expr='SET email = :email, email_verified = :email_verified, \
-                             update_date = :update_date',
+                             updated_at = :updated_at',
             expr_attr_values={
                 ':email': new_email,
                 ':email_verified': email_verified,
-                ':update_date': now_,
+                ':updated_at': now_,
             },
         )
 
@@ -205,8 +215,8 @@ def del_org_member(
 ) -> bool:
     with persistence_layer.transact_writer() as transact:
         # Remove the user's relationship with the organization and their privileges
-        transact.delete(key=KeyPair(id, f'acls#{org_id}'))
-        transact.delete(key=KeyPair(id, f'orgs#{org_id}'))
+        transact.delete(key=KeyPair(id, ComposeKey(org_id, prefix='acls')))
+        transact.delete(key=KeyPair(id, ComposeKey(org_id, prefix='orgs')))
         transact.update(
             key=KeyPair(id, '0'),
             update_expr='DELETE #tenant :org_id',
@@ -215,7 +225,7 @@ def del_org_member(
         )
 
         # Remove the user from the organization's admins and members list
-        transact.delete(key=KeyPair(org_id, f'admins#{id}'))
-        transact.delete(key=KeyPair(f'orgmembers#{org_id}', id))
+        transact.delete(key=KeyPair(org_id, ComposeKey(id, prefix='admins')))
+        transact.delete(key=KeyPair(ComposeKey(org_id, prefix='orgmembers'), id))
 
     return True